Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query cache being left enabled after routing error - second try #3975

Closed
wants to merge 1 commit into from

Conversation

mreinsch
Copy link
Contributor

Ok, here we go again, this time with just one commit.

After a 404 error triggered by a routing error, ActiveRecord's query cache stays enabled.

We observed this issue through something similar as described in issue #2333, where some model test cases started to fail when run after testing a 404 error page. In that case nobody is calling ActiveRecord::QueryCache::BodyProxy#close.

I tracked the issue down to actionpack/lib/action_dispatch/middleware/show_exceptions.rb#call. That one isn't calling close on body.

@josevalim
Copy link
Contributor

Could you please provide a failing test case?

@jeremy
Copy link
Member

jeremy commented Dec 14, 2011

Please do pull requests against the master branch. (Stable branches get backports; they aren't new lines of development.)

@jeremy jeremy closed this Dec 14, 2011
@mreinsch
Copy link
Contributor Author

@andhapp thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants