Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP_REFERER when following redirects on integration tests #40051

Merged
merged 1 commit into from Sep 9, 2022
Merged

Add HTTP_REFERER when following redirects on integration tests #40051

merged 1 commit into from Sep 9, 2022

Conversation

fsateler
Copy link
Contributor

Summary

This changes follow_redirect! to set HTTP_REFERER on the next request, unless it was set in the **args.

Other Information

This makes a closer simulation of what happens in a real browser session

@rails-bot rails-bot bot added the actionpack label Aug 14, 2020
@rails-bot
Copy link

rails-bot bot commented Nov 12, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Nov 12, 2020
@fsateler
Copy link
Contributor Author

unstale, please

@rails-bot rails-bot bot removed the stale label Nov 13, 2020
Base automatically changed from master to main January 14, 2021 17:01
@fsateler fsateler force-pushed the feature/redirect-referer branch 2 times, most recently from 46164a3 to 7e69eeb Compare March 8, 2021 13:48
@rails-bot
Copy link

rails-bot bot commented Jun 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Jun 6, 2021
@ghiculescu
Copy link
Member

I think this is a good idea. @fsateler thanks for your work on it, sorry nobody's had a chance to review it yet. Could you please fix the tests and add a changelog entry?

@rails-bot rails-bot bot removed the stale label Jun 6, 2021
@rails-bot
Copy link

rails-bot bot commented Sep 5, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Sep 5, 2021
@rails-bot rails-bot bot removed the stale label Sep 6, 2021
@fsateler
Copy link
Contributor Author

fsateler commented Sep 6, 2021

Sorry for the delay. Conflicts resolved and CI passes.

@fsateler fsateler closed this Sep 6, 2021
@fsateler fsateler reopened this Sep 6, 2021
@rails-bot
Copy link

rails-bot bot commented Dec 5, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Dec 5, 2021
@ghiculescu ghiculescu added ready PRs ready to merge and removed stale labels Dec 5, 2021
@rails-bot
Copy link

rails-bot bot commented Mar 6, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Mar 6, 2022
@fsateler
Add HTTP_REFERER when following redirects on integration tests
c247eae 
This makes a closer simulation of what happens in a real browser session
@rails-bot rails-bot bot removed the stale label Mar 6, 2022
@rafaelfranca rafaelfranca merged commit 8e65c22 into rails:main Sep 9, 2022
@fsateler fsateler deleted the feature/redirect-referer branch January 24, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpdoyle seanpdoyle seanpdoyle left review comments

Assignees
No one assigned
Labels
actionpack ready PRs ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fsateler @ghiculescu @seanpdoyle @rafaelfranca