Fix preloader to associate preloaded records by default #40056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone had relied on the behavior that preloading with a given scope, but the behavior has lost in rails#35496 to fix the minor bug that unloading through association. Basically we don't guarantee the internal behavior, but the bugfix can be achieved without any breaking change, so I've restored the lost functionality. Fixes rails#36638. Fixes rails#37720.
kamipo
added a commit
that referenced
this pull request
Aug 17, 2020
Fix preloader to associate preloaded records by default
NoahFisher
pushed a commit
to simplepractice/rails
that referenced
this pull request
Nov 12, 2020
…_default Fix preloader to associate preloaded records by default
berowar
pushed a commit
to simplepractice/rails
that referenced
this pull request
Nov 13, 2020
…_default Fix preloader to associate preloaded records by default
|
Heya, any reason this code is in 6-0-stable for 5+ months, but not in any released 6.0 version? |
|
Ping 👋! Thanks for fixing this. Would this be in any 6.0 release soon? |
berowar
pushed a commit
to simplepractice/rails
that referenced
this pull request
May 18, 2021
…_default Fix preloader to associate preloaded records by default
|
@rafaelfranca how come this has been merged almost one year ago and not available in any 6.0.x release? It's a bit weird to me. |
|
@coorasse @qcam @reist I'm not sure if rails-core will cut a release for 6.0.x including this (or if they haven't already) -- but as a workaround have you tried pointing your Gemfile at |
This was referenced Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone had relied on the behavior that preloading with a given scope,
but the behavior has lost in #35496 to fix the minor bug that unloading
through association.
Basically we don't guarantee the internal behavior, but the bugfix can
be achieved without any breaking change, so I've restored the lost
functionality.
Fixes #36638.
Fixes #37720.