Make structure.sql file configureable in db:structure:dump analog to SCHEMA in db:schema:dump

[kommen]

No description provided.

[josevalim]

Why would you want to change the name? There are other places in Rails this file is referenced and if you change just in the rake task, it can cause bugs.

[kommen]

@josevalim: We run the same app against mysql and postgres (in different instances) and we'd like to use separate structure files for them as they obviously differ.

Can you point me to other uses of this file? I checked commit 15fb430 where the file name was changed the last time and it doesn't look like this affected other files then databases.rake.

[josevalim]

We reference it here for dev reloading:

https://github.com/rails/rails/blob/master/activerecord/lib/active_record/railtie.rb#L106

But it seems yours is a production concern, so we are actually fine. A few
things just:

1. Could you please rename the ENV variable from STRUCTURE to DB_STRUCTURE

2. Please update the task description also to mention the new ENV var

3. Please add a simple test here:
   https://github.com/rails/rails/blob/master/railties/test/application/rake_test.rb

Thanks!

[kommen]

Thanks a lot for your feedback José. I've addressed your suggestions.