Support a context for update_attributes / update_attributes! methods.

[kennyj]

Currently, the update_attributes / update_attributes! method can't specify a validation context.
This patch allow above methods to specify the context.

[nashby]

I think you can rewrite it like this:

context = options.delete(:context)

[kennyj]

Oops... You're right !
I'll fix and squash it.
Thanks!

[drogus]

Shouldn't it go to validations.rb?

[kennyj]

@drogus

Considers your proposal, I think the easiest way to fix that next.

$ vim lib/active_record/persistence.rb
208     def update_attributes(attributes, options = {})
209       # The following transaction covers any possible database side-effects of the
210       # attributes assignment. For example, setting the IDs of a child collection.
211       with_transaction_returning_status do
212         self.assign_attributes(attributes, options)
213         save(options) # ★ options argument is passed 
214       end
215     end

What do you think?

[kennyj]

I think the below commit is simplest way.

kennyj@5e1875a

I couldn't go to validations.rb, because I must pass options argument to the save(save!) method.
And if I pass options argument to the save in persistence.rb, I have nothing to do in validations.rb.

[kennyj]

My last comment is simplest way to support this feature, but options for assign_attributes and for save are merged ...
I think that this feature should be supported, but it seems that this implement is not good ;-)
I'm closing this PR.

[andreas]

@kennyj, I think it's a great idea to have context for update_attributes. Any ideas for a smarter implementation? What are the downsides of passing the same options-hash to both assign_attributes and save?

[kennyj]

@andreas I think some unrelated option values were passed to assign_attributes method and we should not merge option values.