Uncomments bin/yarn in bin/setup for webpacker #40265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pftg
force-pushed
the
run-bin-yarn-on-setup-by-default
branch
from
9431c4b
to
572998f
Compare
|
There is an issue with Will check other failed tests |
pftg
force-pushed
the
run-bin-yarn-on-setup-by-default
branch
from
572998f
to
1c5c480
Compare
pftg
changed the title
pftg
force-pushed
the
run-bin-yarn-on-setup-by-default
branch
from
1c5c480
to
52ce567
Compare
pftg
changed the title
|
Fixed all tests related to my changes. There is a flaky test in the master https://buildkite.com/rails/rails/builds/71715#d1f5e263-fef9-449c-b701-45b576f1b05c Could someone check my PR and provide some feedback? |
By adding installing of webpacker, `bin/setup` requires manual update in order to do cold setup. This adds extra steps to generate app and setup it.
pftg
force-pushed
the
run-bin-yarn-on-setup-by-default
branch
from
52ce567
to
133805f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By adding the default requiring of webpacker,
bin/setuprequires a manual update in order to do the cold setup on a new instance.Other Information
If users do not use
bin/yarnto install packages, then they still require to deletebin/yarnline in order to remove redundant code.If we already add
bin/yarn, then run it onbin/setupshould not increase any confusion.And at the same time, we reduce confusion when we run
bin/setupwithoutnode_moduleswill not setup valid application.Cosmetic Changes
There is some cosmetic change which makes code consistent:
system('bin/yarn')=>system! 'bin/yarn'