Bug: ActiveStorage method "attach" not work if model have validation errors

[nPaul]

please fix it

example:

avatar = { io: StringIO.new(Base64.decode64(photo)), filename: "avatar" }
employee = Employee.new name: 'name'
employee.save!(validate: false) # have validation errors
puts employee.persisted?
true
res = employee.avatar.attach(avatar)
puts res
false

puts employee.errors.messages
{:chief=>["must exist"]}
employee.reload
puts employee.avatar.attached?
false

[abhaynikam]

@nPaul Active Storage attach tries to re-save the Active Record. Refer: https://github.com/rails/rails/blob/master/activestorage/lib/active_storage/attached/one.rb#L33

Not sure if attach should accept the argument like validate: false to resolve this issue so not trying to raise a fix for it. But in case that is approved by some Rails team member I can raise a patch for it.

The work-around could be as follows:

avatar = { io: StringIO.new(Base64.decode64(photo)), filename: "avatar" }
employee = Employee.new name: 'name'
employee.avatar.attach(avatar)
employee.save!(validate: false)

[nPaul]

@nPaul Active Storage attach tries to re-save the Active Record. Refer: https://github.com/rails/rails/blob/master/activestorage/lib/active_storage/attached/one.rb#L33

Not sure if attach should accept the argument like validate: false to resolve this issue so not trying to raise a fix for it. But in case that is approved by some Rails team member I can raise a patch for it.

The work-around could be as follows:

avatar = { io: StringIO.new(Base64.decode64(photo)), filename: "avatar" }
employee = Employee.new name: 'name'
employee.avatar.attach(avatar)
employee.save!(validate: false)

Yes it works

But i think it is bug, or not obviously

For example
I have more records with no valid records, created long ago time.
Now i want attach them avatars, but i cant do it.
employee = Employee.find(id) employee.avatar.attach(avatar)

i think method

must using save!(validate: false)
as default
he shouldn't care about valid or invalid model

[rails-bot]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.
If you can still reproduce this error on the 6-1-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.

[khalilgharbaoui]

+1