Do not add newlines when annotating rendered views #40346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rendering a view with annotate_rendered_view_with_filenames enabled, we were inserting newlines after the BEGIN and END comments. These newlines are not ideal in some use cases, such as rendering templates to strings that are then passed around our application. As the newlines were added for aesthetic purposes, we think it makes sense to remove them so that rendered template strings do not contain extraneous newlines. As a result of removing these newlines, the annotations no longer affect the reporting of template error on the correct line, as addressed in #38950. As such, we've reverted those changes as well. Co-authored-by: Chris Gavin <chrisgavin@github.com>
|
🚀 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering a view with
annotate_rendered_view_with_filenamesenabled, we were inserting newlines after the BEGIN and END
comments. These newlines are not ideal in some use cases, such
as rendering templates to strings that are then passed around
our application.
As the newlines were added for aesthetic purposes, we think it
makes sense to remove them so that rendered template strings do
not contain extraneous newlines.
As a result of removing these newlines, the annotations
no longer affect the reporting of template errors on the correct
line, as addressed in #38950. As such, we've reverted those
changes as well.
Co-authored-by: Chris Gavin chrisgavin@github.com
cc @rafaelfranca as the merger of #38950 and @tenderlove as my co-conspirator on
annotate_rendered_view_with_filenames.