Add support for rails console --sandbox for multiple database applications
#40704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpaca-tc
force-pushed
the
sandbox_multiple_database
branch
from
47218b1
to
ae674f5
Compare
alpaca-tc
commented
Nov 28, 2020
| ActiveRecord::Base.connection.begin_transaction(joinable: false) | ||
|
|
||
| at_exit do | ||
| ActiveRecord::Base.connection.rollback_transaction |
There was a problem hiding this comment.
No need to call rollback_transaction manually because the all connections will be rolled back on disconnected/exited.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
alpaca-tc
changed the title
rails console --sandbox for multiple database applicationsrails console --sandbox for multiple database applications
alpaca-tc
changed the title
rails console --sandbox for multiple database applicationsrails console --sandbox for multiple database applications
3GodNight
approved these changes
Nov 28, 2020
| ActiveRecord::Base.connection.begin_transaction(joinable: false) | ||
|
|
||
| at_exit do | ||
| ActiveRecord::Base.connection.rollback_transaction |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
eileencodes
reviewed
Dec 7, 2020
activerecord/CHANGELOG.md
Outdated
| @@ -1,3 +1,9 @@ | |||
| * Add support for `rails console --sandbox` for multiple database applications. | |||
|
|
|||
| Multiple database applications will now be rolled back on exit. | |||
There was a problem hiding this comment.
I don't know if this changelog is really necessary. It implies it's adding support for multiple databases but it's really fixing a bug. We don't add changelogs when fixing a bug. Can you remove this change?
With a multiple database application `rails console --sandbox` becomes problematic. We can't rollback any modifications for every database because we can't open transaction for the connections that haven't not yet been loaded. To solve this I handled that if the database is connected then it will open transaction.
alpaca-tc
force-pushed
the
sandbox_multiple_database
branch
from
ae674f5
to
67517fd
Compare
kamipo
pushed a commit
that referenced
this pull request
Jan 9, 2021
Add support for `rails console --sandbox` for multiple database applications
|
Backported this to 6-1-stable 9cc99d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With a multiple database application
rails console --sandboxbecomes problematic. We can't rollback any modifications for every non-primary database because we can't open transaction for the connections that haven't yet been loaded.To solve this I handled that if the database is connected then it will open transaction. This way can handle all connections.