Quietly handle unknown HTTP methods in Action Dispatch SSL middleware #40930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrobbin
force-pushed
the
action-dispatch-ssl-raw-request-method
branch
from
a40ae3d
to
1dd53a9
Compare
Because `ActionDispatch::SSL` is included higher up in the middleware stack than `ActionDispatch::ShowExceptions`, it should ideally not be raising any exceptions.
In this case, `ActionDispatch::Request#{get,head}?` are called, which check if the HTTP method is valid. If it isn't, `ActionController::UnknownHttpMethod` is raised. Instead of calling the Rack-provided predicate methods, we leverage `raw_request_method`.
agrobbin
force-pushed
the
action-dispatch-ssl-raw-request-method
branch
from
1dd53a9
to
ea40dd3
Compare
rafaelfranca
added a commit
that referenced
this pull request
Dec 28, 2020
…st-method Quietly handle unknown HTTP methods in Action Dispatch SSL middleware
|
Thanks @rafaelfranca! Is it possible to also get this backported to |
|
Wow nevermind, you already did that, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
ActionDispatch::SSLis included higher up in the middleware stack thanActionDispatch::ShowExceptions, it should ideally not be raising any exceptions.In this case,
ActionDispatch::Request#{get,head}?are called, which check if the HTTP method is valid. If it isn't,ActionController::UnknownHttpMethodis raised. Instead of calling the Rack-provided predicate methods, we leverageraw_request_method.This is somewhat related to #40834.