Make config.action_view.button_to_generates_button_tag work
#41055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanvlviv
force-pushed
the
fix-config.action_view.button_to_generates_button_tag
branch
2 times, most recently
from
7c8b05d
to
64ff920
Compare
In rails#40747 we added `ActionView::Helpers::UrlHelper.button_to_generates_button_tag`. - `config.action_view.button_to_generates_button_tag` should configure `ActionView::Helpers::UrlHelper.button_to_generates_button_tag` - Added test cases - Fixed new_framework_defaults_6_2.rb.tt (See rails#40747 (comment), rails#40747 (comment), cc @kaspth) - Added the option to the configuring guide - Documented - Added to "6.2 defaults section - Added to "Baseline defaults" section (see ff88113)
bogdanvlviv
force-pushed
the
fix-config.action_view.button_to_generates_button_tag
branch
from
64ff920
to
4a401ca
Compare
bogdanvlviv
deleted the
fix-config.action_view.button_to_generates_button_tag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #40747 we added
ActionView::Helpers::UrlHelper.button_to_generates_button_tag.config.action_view.button_to_generates_button_tagshould configureActionView::Helpers::UrlHelper.button_to_generates_button_tagbutton_toas<button>#40747 (comment), Consistently renderbutton_toas<button>#40747 (comment), cc @kaspth)