Fix ActiveRecord::ConnectionAdapters::QueryCache#dirties_query_cache #41147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
reviewed
Jan 17, 2021
|
|
||
| assert_equal count + 1, Event.count | ||
| ensure | ||
| Event.find(1)&.destroy |
There was a problem hiding this comment.
Can you use reset_fixtures("posts") and Post model instead?
Suggested change
| Event.find(1)&.destroy | |
| reset_fixtures("posts") |
https://buildkite.com/rails/rails/builds/74129#3b2b1120-8262-4d6a-87b4-d6649ee9155d/1070-1079
There was a problem hiding this comment.
Or, use the returning value for create (id = @connection.create(...)).
Suggested change
| Event.find(1)&.destroy | |
| Event.find(id).destroy if id |
kamipo
reviewed
Jan 17, 2021
| @connection.enable_query_cache! | ||
|
|
||
| count = Event.count | ||
| binds = [[Event.column_for_attribute("id"), 1]] |
There was a problem hiding this comment.
Don't use the deprecated legacy binds (an array of [column || nil, value]).
https://buildkite.com/rails/rails/builds/74129#f336c8d3-da13-4408-8e86-cedecdabba7d/1066-1075
Suggested change
| binds = [[Event.column_for_attribute("id"), 1]] | |
| binds = [1] |
OuYangJinTing
force-pushed
the
fix_query_cache_is_dirty_after_perform_created
branch
2 times, most recently
from
f2d018d
to
6162ce3
Compare
kamipo
reviewed
Jan 17, 2021
Comment on lines
449
to
450
| binds = ["", ""] | ||
| bind_param = Arel::Nodes::BindParam.new(nil) |
There was a problem hiding this comment.
Can you remove unused variables?
Suggested change
| binds = ["", ""] | |
| bind_param = Arel::Nodes::BindParam.new(nil) |
https://github.com/rails/rails/pull/41147/checks?check_run_id=1716707664
OuYangJinTing
force-pushed
the
fix_query_cache_is_dirty_after_perform_created
branch
from
6162ce3
to
79d5712
Compare
|
@kamipo Thank you for your review and suggestions. |
|
Thanks! |
kamipo
added a commit
that referenced
this pull request
Feb 1, 2021
…_after_perform_created Fix ActiveRecord::ConnectionAdapters::QueryCache#dirties_query_cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the active_record/connection_adapters/abstract/database_statements.rb file,
#createmethod is alias of#insertmethod.In the active_record/connection_adapters/abstract/query_cache.rb file,
#createmethod is not cleanup query cache.We should override
#createmethod cleanup query cache too.