Raise unknown type error on the definition time #41166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If unknow type is given for attribute (`attribute :foo, :unknown`), unknown type error isn't raised on the definition time but runtime. It should be raised on the definition time.
kamipo
force-pushed
the
raise_unknown_type_error_on_definition_time
branch
from
bdfa96e
to
26e1fe4
Compare
kamipo
commented
Jan 19, 2021
| @@ -7,7 +7,7 @@ class PostgresqlTime < ActiveRecord::Base | |||
| # Declare attributes to get rid from deprecation warnings on ActiveRecord 6.1 | |||
| attribute :time_interval, :string | |||
| attribute :scaled_time_interval, :interval | |||
| end | |||
| end if current_adapter?(:PostgreSQLAdapter) | |||
There was a problem hiding this comment.
These are for bin/test testing.
bundle exec rake test loads test files for the testing adapter, but bin/test always loads all test files, :interval, :point, and :legacy_point types are registered only for postgresql adapter, now it will raise unknown type error for sqlite3 and mysql2 adapters.
Lines 55 to 57 in 098fd7f
|
We should not connect to the database when defining classes. This can take applications down, and the connection configuration isn't always setup when the class is being defined. |
|
Yeah... I realized that in making #41262, it is due to the implementation of |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Feb 2, 2021
rails#41166 made `attribute` require a connection due to calling `ActiveRecord::Type.adapter_name_from` immediately. This fixes `adapter_name_from` to get the adapter name from the connection db config to not retrieve a connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If unknow type is given for attribute (
attribute :foo, :unknown),unknown type error isn't raised on the definition time but runtime.
It should be raised on the definition time.