Opting out of strict loading on a per-record base

[ayrton]

Summary

Provide a way to opt out of strict loader on a per-record base. This is useful when strict loading is enabled application wide or on model level.

How:

Similar to defining the value of strict_loading on relations we accept an optional value on a record.

This was initially reported in #41171.

[ayrton]

Would love to hear if we should ship with lazy loaded records, when serialization happens through globalid, to avoid having to write:

record.strict_loading!(false)

in your jobs:

module MyApplication
  class Application < Rails::Application
    config.active_record.strict_loading_by_default = true
  end
end

class Subscription < ApplicationRecord
  belongs_to :user
end

class User < ApplicationRecord
  has_many :subscriptions, inverse_of: :user
end

class ArchiveSubscriptionJob < ApplicationJob
  def perform(subscription)
    subscription.strict_loading!(false) # <-- should this be done out-of-the-box?

    user = subscription.user
    # [...]
  end
end

If so I am happy to draft up the code (either in this PR or a different one). Something along the lines of:

# activejob/lib/active_job/arguments.rb
def deserialize_global_id(hash)
  GlobalID::Locator.locate(hash[GLOBALID_KEY]).tap do |record|
    record.strict_loading!(false) if record.respond_to?(:strict_loading!)
  end
end

[eileencodes]

Can you also add a changelog entry?

I'm not sure about the global id issue. You can open a separate PR for discussion after this one is merged.

[eileencodes]

Can you add an assertion that developer.audit_logs doesn't raise? I think we should also have a test showing that it also works if the strict loading is defined in the relation. See strict_loading_audit_logs below.

[ayrton]

Done in 8223023

[eileencodes]

Can you squash your commits into 1? Sorry I should have mentioned when I reviewed the first time!

[ayrton]

Can you squash your commits into 1? Sorry I should have mentioned when I reviewed the first time!

No problem, just finished rebasing and squashing the commits into one

[eileencodes]

Thanks for working on this!

[Roriz]

user.strict_loading!(false)