Respect ActiveStorage default serving strategy #41186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliismayilov
force-pushed
the
resolve_model_to_route-rails_storage_proxy
branch
from
1f66f50
to
0a35464
Compare
aliismayilov
force-pushed
the
resolve_model_to_route-rails_storage_proxy
branch
from
0a35464
to
80f99a5
Compare
aliismayilov
force-pushed
the
resolve_model_to_route-rails_storage_proxy
branch
from
80f99a5
to
8fe05ba
Compare
There was a problem hiding this comment.
Looks reasonable to me. I'll pass this off to the folks with commit access. @georgeclaghorn perhaps?
Co-authored-by: Daniel Colson <daniel.colson@hey.com>
|
@rafaelfranca could you please include this PR in the next rails 6.1 release as well? The bug is fixed on the main branch, but still exists in rails 6.1.x releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #41172
Summary
rails_blob_pathandrails_blob_urlshould be generating urls based on the ActiveStorage default serving strategy.Other Information
I wasn't sure where/if to add the changelog. Please let me know how to proceed.