Fix deprecation message s/Rails 6.1 will return/Rails 7.0 will return/ #41251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`return_only_media_type_on_content_type` will be introduced in Rails 6.2 so the changing of returning Content-Type will happen in a future version of Rails (probably 7.0).
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Feb 2, 2021
This pull request addresses these warnings. ```ruby $ cd actionmailbox $ bin/test test/controllers/ingresses/relay/inbound_emails_controller_test.rb Run options: --seed 32561 DEPRECATION WARNING: Rails 7.0 will return Content-Type header without modification. If you want just the MIME type, please use `#media_type` instead. (called from call at /home/yahonda/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/rack-2.2.3/lib/rack/tempfile_reaper.rb:15) ...DEPRECATION WARNING: Rails 7.0 will return Content-Type header without modification. If you want just the MIME type, please use `#media_type` instead. (called from call at /home/yahonda/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/rack-2.2.3/lib/rack/tempfile_reaper.rb:15) .. Finished in 0.114883s, 43.5224 runs/s, 87.0447 assertions/s. 5 runs, 10 assertions, 0 failures, 0 errors, 0 skips $ ``` Follow-up rails@84055130713 related to rails#41251
kamipo
added a commit
that referenced
this pull request
Feb 5, 2021
`return_only_media_type_on_content_type` will be introduced in Rails 7.0 so the changing of returning Content-Type will happen in a future version of Rails. Follow up to #41251.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return_only_media_type_on_content_typewill be introduced in Rails 6.2so the changing of returning Content-Type will happen in a future
version of Rails (probably 7.0).
cc @rafaelfranca