Added compact_value for active support enumerable arrays #41285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Feb 19, 2021
Ref: rails#41385 Otherwise the association isn't marked as loaded, and a ThroughAssociation might perform the same query uselessly. `already_loaded?` also has to be made lazy, because rails#41285 made it so that alls the preloaders are instiated together before being ran.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compact_value method active support enumerable arrays. It will remove all matching elements passed as parameters.
and also it removes nil after it.