Harmonize average aggregation with minimum and maximum #41418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
approved these changes
Feb 11, 2021
schmijos
force-pushed
the
regression-for-40351
branch
from
b9a0ec7
to
616b7d1
Compare
kamipo
reviewed
Feb 12, 2021
kamipo
reviewed
Feb 12, 2021
schmijos
force-pushed
the
regression-for-40351
branch
from
616b7d1
to
d24d254
Compare
schmijos
force-pushed
the
regression-for-40351
branch
from
d24d254
to
ed2fddb
Compare
kamipo
reviewed
Feb 12, 2021
| @@ -389,6 +394,11 @@ def execute_grouped_calculation(operation, column_name, distinct) #:nodoc: | |||
| result[key] = type_cast_calculated_value(row[column_alias], operation) do |value| | |||
| type ||= column.try(:type_caster) || | |||
| lookup_cast_type_from_join_dependencies(column_name.to_s) || Type.default_value | |||
|
|
|||
| if operation == "average" && type.is_a?(Type::Integer) | |||
| type = Type::Decimal.new | |||
There was a problem hiding this comment.
type comes in from above. It will be kept while looping. Isn't that an issue?
There was a problem hiding this comment.
It is intentionally kept since the block will be evaluated multiple times and lookup_cast_type_from_join_dependencies is a bit expensive.
There was a problem hiding this comment.
Ok. I took in the second (identical) proposal as well because memoization is only there for expensive lookup_cast_type_from_join_dependencies.
kamipo
reviewed
Feb 12, 2021
schmijos
force-pushed
the
regression-for-40351
branch
from
ed2fddb
to
5a12ba9
Compare
The real problem behind the previous implementation of average aggregation was not that float columns returned `BigDecimal` but that average skipped `ActiveModel` type casting. This change introduces handling for the only needed special case of average: integers. Now any fields based on `ActiveRecord::Type::Integer` will be casted to `BigDecimal` when aggregated with average.
schmijos
force-pushed
the
regression-for-40351
branch
from
5a12ba9
to
1a9b843
Compare
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Feb 13, 2021
Follow up to rails#40351 and rails#41418. This fixes `average` on decimal and enum (on integer in general) attributes to not do `type.deserialize`. The precision and the scale on the column might be lower than the calculated result. And also, mapping the calculated result to enum label is quite meaningless, the mapping result is almost nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real problem behind the previous implementation of average
aggregation was not that float columns returned
BigDecimalbut thataverage skipped
ActiveModeltype casting.This change introduces handling for the only needed special case
of average: integers. Any integer based fields will be casted to
BigDecimalwhen aggregated with average now.