Action Text rich text area tag should use to_trix_html value #41514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaynikam
force-pushed
the
fixes-rich-text-area-tag-scenario
branch
from
700b16c
to
67b3ee2
Compare
|
I think we should have input_tag = hidden_field_tag(name, value.try(:to_trix_html) || value, id: options[:input])/cc @javan |
abhaynikam
force-pushed
the
fixes-rich-text-area-tag-scenario
branch
2 times, most recently
from
5e0f098
to
50dceba
Compare
|
@georgeclaghorn Thank you for the feedback. Implemented the suggested changes. |
georgeclaghorn
suggested changes
Feb 27, 2021
abhaynikam
force-pushed
the
fixes-rich-text-area-tag-scenario
branch
from
50dceba
to
413f7ee
Compare
|
@georgeclaghorn Addressed all the comments. Please have another look 馃槉 |
A belated 馃憤 from me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #38027 (comment)
This PR aims to suggest to use
to_trix_htmlinstead of action textto_swhen usingrich_text_area_tag. Added a delegate in the model to maketo_trix_htmlmethod available easier similar toto_sorto_plain_text. Not sure if this would require changelog entry. Please do let me know and I'll add the changelog if needed 馃槉