Inject route with namespace into existing blocks #41584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows successive invocations of the `route` generator action to re-use existing `namespace` blocks.
jonathanhefner
force-pushed
the
route-action-reuse-existing-namespace
branch
from
1902f84
to
106e20d
Compare
|
@jonathanhefner I believe so. The only use case I really had was inserting into an existing namespace. 👍 |
excid3
reviewed
Mar 2, 2021
| routing_code = optimize_indentation(routing_code, base_indent + 2).lines.grep_v(/^[ ]{,#{prev_indent}}\S/).join | ||
| end | ||
|
|
||
| inject_into_file "config/routes.rb", routing_code, after: after_pattern, verbose: false, force: false |
There was a problem hiding this comment.
What do you think about making the routes file configurable since draw was added in #37892 ?
For example, with the admin gem I'm working on, it'd be great to be able to add draw :admin to the main routes.rb and have our generators add routes to config/routes/admin.rb
There was a problem hiding this comment.
That sounds like a good idea. Though I would prefer to do it in a follow-up PR.
|
fyi #43950 |
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Dec 24, 2021
Follow-up to rails#41584. Thor uses a regexp with its own capture groups when revoking an `inject_into_file` call. Thus an `:after` regexp containing capture groups will interfere with Thor's regexp. This commit changes the `:after` regexp we pass to `inject_into_file` so that it no longer contains capture groups. This commit also cleans up any newly-empty namespace blocks when revoking a route, since `inject_into_file` does not handle that. The majority of this commit is refactoring and clean-up. The actual regexp fix is just the following line: ```ruby namespace_pattern = /#{Regexp.escape namespace_match.to_s}/ ``` Fixes rails#43950.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows successive invocations of the
routegenerator action to re-use existingnamespaceblocks.