Add Preloader::Association::LoaderQuery #41597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
reviewed
Mar 3, 2021
activerecord/lib/active_record/associations/preloader/association.rb
Outdated
Show resolved
Hide resolved
kamipo
reviewed
Mar 4, 2021
activerecord/lib/active_record/associations/preloader/association.rb
Outdated
Show resolved
Hide resolved
jhawthorn
force-pushed
the
preloader_batch_loader_query
branch
from
761c038
to
4ef978c
Compare
kamipo
reviewed
Mar 5, 2021
activerecord/lib/active_record/associations/preloader/association.rb
Outdated
Show resolved
Hide resolved
kamipo
reviewed
Mar 5, 2021
jhawthorn
force-pushed
the
preloader_batch_loader_query
branch
from
4ef978c
to
bd17401
Compare
Co-authored-by: Ryuta Kamizono <kamipo@gmail.com>
This class represents the query a Preloader::Association uses to load its records. This replaces the previous concept of a grouping_key and serves both to group Preloader::Associations by their query and to run the query to load the records (which nicely avoids using .first). This should not change any functionality but should be slightly faster due to being able to avoid calling `scope.to_sql` unless necessary.
jhawthorn
force-pushed
the
preloader_batch_loader_query
branch
from
bd17401
to
eeef0bb
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #41385
This class represents the query a
Preloader::Associationuses to load its records. This replaces the previous concept of a grouping_key and serves both to groupPreloader::Associationsby their query and to run the query to load the records (which nicely avoids using.first).This should not change any functionality but should be slightly faster due to being able to avoid calling
scope.to_sqlunless necessary.cc @dinahshi @eileencodes @HParker