Deprecate legacy_connection_handling #41859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marivaldo
reviewed
Apr 6, 2021
| @@ -379,7 +381,9 @@ def test_retrieve_connection_pool_with_invalid_id | |||
| end | |||
|
|
|||
| def test_connection_handlers_are_per_thread_and_not_per_fiber | |||
| ActiveRecord::Base.connection_handlers = { writing: ActiveRecord::Base.default_connection_handler, reading: ActiveRecord::ConnectionAdapters::ConnectionHandler.new } | |||
| assert_deprecated do | |||
| ActiveRecord::Base.connection_handlers = { writing: ActiveRecord::Base.default_connection_handler, reading: ActiveRecord::ConnectionAdapters::ConnectionHandler.new } | |||
There was a problem hiding this comment.
Suggested change
| ActiveRecord::Base.connection_handlers = { writing: ActiveRecord::Base.default_connection_handler, reading: ActiveRecord::ConnectionAdapters::ConnectionHandler.new } | |
| ActiveRecord::Base.connection_handlers = { | |
| writing: ActiveRecord::Base.default_connection_handler, | |
| reading: ActiveRecord::ConnectionAdapters::ConnectionHandler.new | |
| } |
marivaldo
reviewed
Apr 6, 2021
| @@ -392,7 +396,9 @@ def test_connection_handlers_are_per_thread_and_not_per_fiber | |||
| end | |||
|
|
|||
| def test_connection_handlers_swapping_connections_in_fiber | |||
| ActiveRecord::Base.connection_handlers = { writing: ActiveRecord::Base.default_connection_handler, reading: ActiveRecord::ConnectionAdapters::ConnectionHandler.new } | |||
| assert_deprecated do | |||
| ActiveRecord::Base.connection_handlers = { writing: ActiveRecord::Base.default_connection_handler, reading: ActiveRecord::ConnectionAdapters::ConnectionHandler.new } | |||
There was a problem hiding this comment.
Suggested change
| ActiveRecord::Base.connection_handlers = { writing: ActiveRecord::Base.default_connection_handler, reading: ActiveRecord::ConnectionAdapters::ConnectionHandler.new } | |
| ActiveRecord::Base.connection_handlers = { | |
| writing: ActiveRecord::Base.default_connection_handler, | |
| reading: ActiveRecord::ConnectionAdapters::ConnectionHandler.new | |
| } |
There was a problem hiding this comment.
Thanks for the suggestions. I'm didn't merge in the suggested changes because it's deprecated code, and they're just tests. 😄
This deprecates `legacy_connection_handling` via the `connection_handlers` setter. This is called from the ActiveRecord Railtie on boot and since most applications don't set this themselves this will prevent the deprecation from being raised multiple times for a test run or in development. I've also updated the guides to include a migration path for applications using the deprecated methods. The majority of applications won't need to make any changes.
eileencodes
force-pushed
the
deprecate-legacy-connection-handling
branch
from
4196be9
to
634bf89
Compare
abhaynikam
reviewed
Apr 7, 2021
| The new connection handling does not support `connection_handlers` | ||
| getter and setter. | ||
|
|
||
| Read more about how to migrate at: |
There was a problem hiding this comment.
Read more link is missing. Is it intentionally left blank until guide changes are released?
We can use https://guides.rubyonrails.org/active_record_multiple_databases.html#migrate-to-the-new-connection-handling considering after guide release the link would work fine.
There was a problem hiding this comment.
Whoops, thanks for catching that. I pushed a fix in b8b1c9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates
legacy_connection_handlingvia theconnection_handlerssetter. This is called from the ActiveRecordRailtie on boot and since most applications don't set this themselves
this will prevent the deprecation from being raised multiple times for a
test run or in development.
I've also updated the guides to include a migration path for
applications using the deprecated methods. The majority of applications
won't need to make any changes.