Freeze ActiveSupport::Duration#parts hash #41906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Durations are meant to be value objects and should not be mutated.
By doing this we can cache whether a duration is variable and give the
+
and-
methods onActiveSupport::Duration
a performance boost. It also avoids two array allocations by avoiding theany?
and the inline array definition. It's not going to make a big performance difference to apps but it makes theduration_of_variable_length?
method 2.5 times faster:I've removed the
parts=
andvalue=
methods since these should never be used on a duration.I've also made
parts
return a copy of the frozen hash and added a_parts
reader so that we can access the parts internally without paying the tax of thedup
.