Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop checking if ruby2_keywords is defined #41907

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

casperisfine
Copy link
Contributor

Now that Ruby 2.7+ is required, we can assume ruby2_keywords is available.

cc @kamipo

@byroot byroot merged commit 97b87dc into rails:main Apr 11, 2021
@casperisfine casperisfine deleted the remove-ruby2-keywords-check branch April 11, 2021 11:54
@rafaelfranca
Copy link
Member

We don't call method modifiers in the same line as the method definition. I'll change it to be after the method definition like it was before.

@byroot
Copy link
Member

byroot commented Apr 12, 2021

Sorry, didn't know. I can clean it up if you want.

@rafaelfranca
Copy link
Member

I already did. BTW, do we still need to call it if we are only supporting Ruby 2.7? Can't we split the args from kwargs in all those methods?

@byroot
Copy link
Member

byroot commented Apr 12, 2021

Unfortunately no, it's still ambiguous on 2.7. So they'll have to stay until support for it is dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants