Allow to pass the method signature when defining attribute methods #41911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves some array allocations from avoiding `*args`, as well as makes the Method object `arity` and `parameters` correct. e.g. before this patch, ArgumentError would be confusing: ```ruby >> model.name_was(1) ArgumentError: wrong number of arguments (given 2, expected 1) ```
rafaelfranca
approved these changes
Apr 12, 2021
alpaca-tc
added a commit
to alpaca-tc/active_record_bitmask
that referenced
this pull request
Sep 29, 2021
In Rails 7.0.0, `#attribute?` with arguments doesn't work. Because rails/rails#41911 introduced new behavior for attribute methods to raise exception when unnecessary arguments given. Therefore can't use `attribute?` for bitmask in Rails 7.0.0. This changes are followings. - Warn deprecation warning when using `attribute?` for bitmask attribute. - Add `attribute_bitmask?` to support same behavior. This works fine in Rails 7.0.0.
alpaca-tc
added a commit
to alpaca-tc/active_record_bitmask
that referenced
this pull request
Sep 29, 2021
In Rails 7.0.0, `#attribute?` with arguments doesn't work. Because rails/rails#41911 introduced new behavior for attribute methods to raise exception when unnecessary arguments given. Therefore can't use `attribute?` for bitmask in Rails 7.0.0. This changes are followings. - Warn deprecation when using `attribute?` for bitmask attribute. - Add `attribute_bitmask?` to support same behavior. This works fine in Rails 7.0.0.
alpaca-tc
added a commit
to alpaca-tc/active_record_bitmask
that referenced
this pull request
Sep 29, 2021
In Rails 7.0.0, `#attribute?` with arguments doesn't work. Because rails/rails#41911 introduced new behavior for attribute methods to raise exception when unnecessary arguments given. Therefore can't use `attribute?` for bitmask in Rails 7.0.0. This changes are followings. - Warn deprecation when using `attribute?` for bitmask attribute. - Add `attribute_bitmask?` to support same behavior. This works fine in Rails 7.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a rebase of #38356
This saves some array allocations from avoiding
*argsand is generallymarginally faster. Actually it is over twice as fast.It also makes the Method object
arityandparameterscorrect.e.g. before this patch,
ArgumentErrorwould be confusing:For backward compatibility reasons, the parameters list defaults to
"*args".