chore: fix spelling in railties/test/generators #41923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbampton
commented
Apr 13, 2021
| @@ -31,13 +31,13 @@ def test_invoke_other_generator_with_full_namespace | |||
| end | |||
|
|
|||
| def test_create_file_should_write_data_to_file_path | |||
| action :create_file, "lib/test_file.rb", "heres test data" | |||
| assert_file "lib/test_file.rb", "heres test data" | |||
| action :create_file, "lib/test_file.rb", "here's test data" | |||
There was a problem hiding this comment.
here's is a contraction of here is
Suggested change
| action :create_file, "lib/test_file.rb", "here's test data" | |
| action :create_file, "lib/test_file.rb", "here is test data" |
|
Hey @zzak my new |
|
Hey @georgeclaghorn or @jonathanhefner how about a review ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed
herestohere's