Combine FileSystemResolver classes #41969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
approved these changes
Apr 14, 2021
|
Looks like the failing assertion is this one: Which fails because you've removed the deprecation, so we should be able to safely remove the assertion line too. |
This was previously deprecated in Rails 6.1 (and never quite behaved correctly)
This is no longer used
jhawthorn
force-pushed
the
combine_file_system_resolvers
branch
from
8e1ca9d
to
c70bd13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the previous three classes of
OptimizedFileSystemResolver,FileSystemResolver, andPathResolverinto a singleFileSystemResolverwhich has the same behaviour as the previousOptimizedFileSystemResolver. After all, why wouldn't we want it always optimized 馃槈.This is possible because we've removed the
FallbackFileSystemResolverin #41846 and this PR removes support for template names including a "." (which was deprecated in Rails 6.1). This means that all supported behaviours are handled by the optimized version of the resolver.