Raise a meaningful error if ActiveStorage::Current.host is blank #41996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl/custom-error-without-as-current-host
branch
from
aab8a35
to
db7767e
Compare
kennyadsl
changed the title
kennyadsl
force-pushed
the
kennyadsl/custom-error-without-as-current-host
branch
from
db7767e
to
4f30eaf
Compare
eileencodes
requested changes
May 10, 2021
| @@ -124,6 +124,10 @@ def generate_url(key, expires_in:, filename:, content_type:, disposition:) | |||
| purpose: :blob_key | |||
| ) | |||
|
|
|||
| if current_host.blank? | |||
| raise "Cannot generate URL for #{filename} using Disk service, please set ActiveStorage::Current.host." | |||
There was a problem hiding this comment.
I think this should use argument error instead:
Suggested change
| raise "Cannot generate URL for #{filename} using Disk service, please set ActiveStorage::Current.host." | |
| raise ArgumentError, "Cannot generate URL for #{filename} using Disk service, please set ActiveStorage::Current.host." |
There was a problem hiding this comment.
@eileencodes thanks for the review. Your suggestion makes perfect sense to me, I've updated the PR accordingly. 🙂
kennyadsl
force-pushed
the
kennyadsl/custom-error-without-as-current-host
branch
from
4f30eaf
to
10f2a9d
Compare
It's very hard to understand what happens with the following exception
URI::InvalidURIError:
bad URI(is not URI?): nil
that is raised when trying to generate a URL for Disk service without
setting the ActiveStorage::Current.host first.
This can happen when the ActiveStorage::SetCurrent is not included
in a controller, or when testing URL generation outside of the
controllers layer (eg. testing URL generation in a model).
Co-authored-by: elia <elia@schito.me>
Co-authored-by: filippo <dev@mailvore.com>
kennyadsl
force-pushed
the
kennyadsl/custom-error-without-as-current-host
branch
from
10f2a9d
to
f971a3f
Compare
eileencodes
approved these changes
May 10, 2021
|
Thanks for the PR and congrats on your first Rails commit 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's very hard to understand what happens with the following exception
that is raised when trying to generate a URL for Disk service without setting the
ActiveStorage::Current.hostfirst.This can happen when the
ActiveStorage::SetCurrentis not included in a controller, or when testing URL generation outside of the controllers layer (eg. testing URL generation in a model).cc @elia @filippoliverani