Perform details matching on UnboundTemplates #42004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspth
approved these changes
Apr 19, 2021
In old versions of Rails, we would rely entirely on what was returned by Dir.glob to determine the match and sorting of our templates. Later we switched to building a regex on each search, which allowed us to perform a much faster glob, find matching templates with the regex, and then emulate the sort order based on captures from the regex. Now we have PathParser, which can parse any template's details accurately from just its filename (not depending on the query being made). This commit moves the matching to done on UnboundTemplates, effectively using details found by the PathParser for both matching and sorting of templates, and removing the dynamic regex for queries. This should be faster at boot/after reloads as we're no longer building a regex and additionally we only need to parse a template's path for details one time (we can use the same details for matching/sorting in future queries with different details).
jhawthorn
force-pushed
the
unbound_template_filtering
branch
from
372d5fd
to
9e0c42b
Compare
ricardotk002
added a commit
to ricardotk002/rails
that referenced
this pull request
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In old versions of Rails, we would rely entirely on what was returned by
Dir.globto determine the match and sorting of our templates.Later we switched to building a regex on each search, which allowed us to perform a much faster glob, find matching templates with the regex, and then emulate the sort order based on captures from the regex.
Now we have
PathParser, which can parse any template's details accurately from just its filename (not depending on the query being made).This PR moves the matching to done on
UnboundTemplates, effectively using details found by thePathParserfor both matching and sorting of templates, and removing the dynamic regex for queries.This should be faster at boot/after reloads as we're no longer building a regex and additionally we only need to parse a template's path for details one time (we can use the same details for matching/sorting in future queries with different details).