Revert autosave breaking change until fix is implemented #42104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tonkpils
changed the title
This reverts commit ae56ecd.
The change introduced in rails#41860 triggered some endless loops which is now reverted by e424c41512e8779663c1bcd222b31c272af811ca This test is just to ensure the behavior is documented once we address both the endless loop and behavior change around update callbacks mentioned rails#42002 (comment)
As mentioned in rails#42002 (comment), rails#41860 introduced a behavior change in callbacks whenever `update_attribute` is called within a `before_*` callback triggered by a `create` which caused `after_update` callbacks to be triggered by the create. This ensures once the revert is re-reverted we'll have properly addressed the fix
Tonkpils
force-pushed
the
revert-autosave-breaking-change-until-fix
branch
from
bb1c687
to
52c2fa9
Compare
|
Sounds good to me. I’ll add tests next week to prevent the regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#41860 introduced two changes in behavior that need to be addressed prior to bringing it back.
Endless loop on update_attribute in callback which was promptly addressed by #42002
Update callbacks called on create if
update_attributeis called inside a before_* callback which @p8 is still looking into.In the mean time, I put together this revert PR to unblock the GitHub rails upgrade and ensure there's no other issues with main.
/cc @eileencodes