Display a help message if rails new is called without a path
#42220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
commented
May 13, 2021
railties/lib/rails/command.rb
Outdated
| @@ -92,6 +93,10 @@ def print_commands # :nodoc: | |||
| COMMANDS_IN_USAGE = %w(generate console server test test:system dbconsole new) | |||
| private_constant :COMMANDS_IN_USAGE | |||
|
|
|||
| def rails_new_with_no_path?(args, config) | |||
There was a problem hiding this comment.
I couldn't find a way in thor to have behavior run if a required argument is missing. It just aborts.
So instead I chose to handle this before we even reach the thor layer.
|
Can you add a test in railties/test/generators/app_generator_test.rb? |
Fixes rails#42196 Now, `rails new` will display the same error message that `rails` and `rails help new` does. To test: - Pull this branch - Uninstall your local rails copy using `gem uninstall rails` - Move into the root directory where you pulled down the rails code, then install: `rake install` - In another directory run `rails new`
ghiculescu
force-pushed
the
rails-new-no-path-provided
branch
from
b78e864
to
34ff6a0
Compare
ghiculescu
commented
May 14, 2021
| class Rails::Command::ApplicationTest < ActiveSupport::TestCase | ||
| test "rails new without path prints help" do | ||
| output = capture(:stdout) do | ||
| Rails::Command.invoke(:application, %w[new]) |
There was a problem hiding this comment.
@eileencodes the app_generator_test tests the thor command directly, so I needed to put my test a few layers higher in the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42196
Previously calling
rails newwithout an app path displayed an error message that wasn't very friendly.Not it will display the same usage message that
railsandrails help newdoes.To test (copied from #39282):
gem uninstall railsrake installrails new