Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AbstractController::Base
definesprocess_action
as private, but modules included after redefine it as a public method.I also fixed the indentation in actionpack/lib/action_controller/metal/instrumentation.rb, I kept it separate for easier review but I can squash it.
Other Information
Doing this removes
process_action
from the docs (there's still ActionController::LogSubscriber#process_action).Maybe we should make it visible to the documentation in
AbstractController::Base
, given the comment and the fact that it's then overridden by things outside actionpack likeActiveRecord::Railties::ControllerRuntime
:rails/actionpack/lib/abstract_controller/base.rb
Lines 221 to 223 in 75ac626
cc @rafaelfranca @byroot