Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private process action #42221

Merged
merged 2 commits into from
May 13, 2021
Merged

Conversation

etiennebarrie
Copy link
Contributor

Summary

AbstractController::Base defines process_action as private, but modules included after redefine it as a public method.

I also fixed the indentation in actionpack/lib/action_controller/metal/instrumentation.rb, I kept it separate for easier review but I can squash it.

Other Information

Doing this removes process_action from the docs (there's still ActionController::LogSubscriber#process_action).

Maybe we should make it visible to the documentation in AbstractController::Base, given the comment and the fact that it's then overridden by things outside actionpack like ActiveRecord::Railties::ControllerRuntime:

# Call the action. Override this in a subclass to modify the
# behavior around processing an action. This, and not #process,
# is the intended way to override action dispatching.

cc @rafaelfranca @byroot

AbstractController::Base defines process_action as private, but modules
included after redefine it as a public method.
@rails-bot rails-bot bot added the actionpack label May 13, 2021
@byroot byroot merged commit 817148a into rails:main May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants