Fixes ActiveStorage#has_many_attached re-creating destroyed attachment #42224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes rails#41862 ActiveStorage#has_many_attached with `config.active_storage.replace_on_assign_to_many = false` flag set to flase always appends new attachments to the association. As mentioned in the issue, if you use nested attributes along with flag disabled and mark some of the attachment to be `destroyed?`. The attachment is destroyed but get re-created without blob upload. This also results in `ActiveStorage#purge_job` failing with rollback. This PR intends to resolve the issue by checking if the attachment is persisted when `#save` is invoked. Only persisted and attachment records are saved which patches the issues.
abhaynikam
force-pushed
the
41862-active-storage-has-many-attached-with-nested-attributes
branch
from
e37ce2a
to
15d5b75
Compare
abhaynikam
deleted the
41862-active-storage-has-many-attached-with-nested-attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #41862
ActiveStorage#has_many_attached with
config.active_storage.replace_on_assign_to_many = falseflag set to flase always appends new attachments to the association.
As mentioned in the issue, if you use nested attributes along with
flag disabled and mark some of the attachment to be
destroyed?.The attachment is destroyed but get re-created without blob upload.
This also results in
ActiveStorage#purge_jobfailing with rollback.This PR intends to resolve the issue by checking if the attachment is
persisted when
#saveis invoked. Only persisted and attachmentrecords are saved which patches the issues.