Fix ActiveStorage intermittent test #42226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
main
branch is failing https://buildkite.com/rails/rails/builds/77422 since #42224 was merged. The problem is that the test needs to use theActiveStorage::Attachment
id
not theActiveStorage::Blob
id
.The intermittency is there because sometimes the
id
of both match. In order to consistently reproduce the failure (before this PR) you can run:bundle exec rake TESTOPTS="--seed=26565"
cc: @eileencodes