Fix primary_abstract_class in lazy loaded envs #42239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have an application that has `ApplicationRecord` and another class like `PrimaryApplicationRecord` and the `PrimaryApplicationRecord` is set to `primary_abstract_class`, then in a lazy loaded env like development, it's possible for `application_record_class` to be set to `ApplicationRecord`. This would then raise an error that you can't reset the class if you then loaded `PrimaryApplicationRecord`. To fix this we've removed the setter for `application_record_class` in the fall through so that if this does happen, `ApplicationRecord` will only be the primary class until the correct primary class is loaded. If an application sets 2 classes to `primary_abstract_class`, the error will still be raised. Co-authored-by: John Crepezzi <john.crepezzi@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have an application that has
ApplicationRecordand anotherclass like
PrimaryApplicationRecordand thePrimaryApplicationRecordis set to
primary_abstract_class, then in a lazy loaded env likedevelopment, it's possible for
application_record_classto be set toApplicationRecord. This would then raise an error that you can't resetthe class if you then loaded
PrimaryApplicationRecord.To fix this we've removed the setter for
application_record_classinthe fall through so that if this does happen,
ApplicationRecordwillonly be the primary class until the correct primary class is loaded.
If an application sets 2 classes to
primary_abstract_class, the errorwill still be raised.
Co-authored-by: John Crepezzi <john.crepezzi@gmail.com