-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test dummy application defaults to remove warnings #42286
Conversation
👍 Active Storage and Action Text also have dummy apps, which have the same problem: https://buildkite.com/rails/rails/builds/77642#459f0e23-956a-4900-b577-692fc85b0c69/1067-1083 |
@eugeneius Thanks! I will patch those too and put them in this same commit |
064276f
to
72add4f
Compare
@eugeneius Done! 🙏 |
Ok I see some actually relevant errors in CI:
Will work on fixing these first. |
72add4f
to
dcef4a3
Compare
Affected gems: * actionmailbox * activestorage * actiontext This fixes the following warning: DEPRECATION WARNING: Using legacy connection handling is deprecated. Please set `legacy_connection_handling` to `false` in your application. The new connection handling does not support `connection_handlers` getter and setter. Read more about how to migrate at: https://guides.rubyonrails.org/active_record_multiple_databases.html#migrate-to-the-new-connection-handling (called from require at ~/.gem/ruby/3.1.0/gems/zeitwerk-2.4.2/lib/zeitwerk/kernel.rb:34)
dcef4a3
to
c797ce9
Compare
@eugeneius I fixed the ActionMailbox tests and pulled in some commits from #42543 that fixed the ActiveStorage tests. This should be good to go 🙏 |
@zzak thanks! 👍🏻 |
Would it be possible to backport this change to 6.1, as I've actually run into a bug using
|
Affected gems:
This fixes the following warning: