Add tests for ArgumentError errors in finder methods #42287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjaimem
force-pushed
the
enhancement/add-tests-for-argument-error-on-finder-methods
branch
from
c459792
to
93c15c3
Compare
zzak
approved these changes
May 25, 2021
martinjaimem
deleted the
enhancement/add-tests-for-argument-error-on-finder-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes enhancements to the tests of the
ArgumentErrorerror message for some finder methods:#findwith an instance ofActiveRecord::Base(now checks the error message).#exists?with an instance ofActiveRecord::Base(now checks the error message).#updatewith an instance ofActiveRecord::Base