Add tests for argument error messages in ActiveRecord methods

[martinjaimem]

Summary

• Added test for the error message of #save!
• Added test for the error message of #update_all
• Added test for the error message of #scoping

[zzak]

@martinjaimem It seems some tests are failing, can you check it?

Failure:
--
  | PersistenceTest#test_save! [/rails/activerecord/test/cases/persistence_test.rb:306]:
  | --- expected
  | +++ actual
  | @@ -1 +1 @@
  | -"Failed to save the record"
  | +"Validation failed: Content Empty, Title Empty"

https://buildkite.com/rails/rails/builds/77667#63685ee8-b181-44b3-98a1-097069449dbe

[martinjaimem]

@martinjaimem It seems some tests are failing, can you check it?

Failure:
--
  | PersistenceTest#test_save! [/rails/activerecord/test/cases/persistence_test.rb:306]:
  | --- expected
  | +++ actual
  | @@ -1 +1 @@
  | -"Failed to save the record"
  | +"Validation failed: Content Empty, Title Empty"

https://buildkite.com/rails/rails/builds/77667#63685ee8-b181-44b3-98a1-097069449dbe

Thanks @zzak , I think I got it right now.

Do you think it's a good idea to improve the error message for the case when the record is already destroyed, and add a custom error message for that?

[zzak]

@martinjaimem LGTM, what is the current error for that case? Could you submit a PR? 🙇