and loading from DB is not possible

Possibly a stupid question, but does it make sense to favour the database over what we have in memory?

Thinking about my test from #42387, if I adapt it to the following:

  def test_nonfiction_book_has_author
    author = Author.new(name: "Author")
    book = Book.new(author: author, title: "Book")
    book.save!
    nonfiction_book = NonfictionBook.new(book: book, subject_area: "Ruby on Rails")

    author.update!(name: "New Author")

    assert_equal book.author.name, author.name
    assert_equal nonfiction_book.author.name, author.name
  end

If we load from the database in the has_one through: case, do we not end up with nonfiction_book.author.name being "New Author" while book.author.name stays as "Author"?

and loading from DB is not possible

Possibly a stupid question, but does it make sense to favour the database over what we have in memory?

Thinking about my test from #42387, if I adapt it to the following:

  def test_nonfiction_book_has_author
    author = Author.new(name: "Author")
    book = Book.new(author: author, title: "Book")
    book.save!
    nonfiction_book = NonfictionBook.new(book: book, subject_area: "Ruby on Rails")

    author.update!(name: "New Author")

    assert_equal book.author.name, author.name
    assert_equal nonfiction_book.author.name, author.name
  end

If we load from the database in the has_one through: case, do we not end up with nonfiction_book.author.name being "New Author" while book.author.name stays as "Author"?

Honestly I didn't run the above piece of code but I think it should use the DB already in such situation because we set the FK: https://github.com/rails/rails/blob/main/activerecord/lib/active_record/associations/association.rb#L281

This PR handles the case when the associations were not already persisted without impacting the already existing behaviour.

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

still relevant

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

ping

@intrip nice PR 👍. I think this is causing an issue for me. Using a has_one through a delegated type relationship and the active record object is returning nil.

@mpmenne I don't understand how this could cause you issue since is not merged yet: are you using this patch in your codebase?

If so could you please provide me a code example?

@intrip sorry. I meant to say #42387 was causing me an issue. Would love to see this PR merged. Sorry for the confusion.