Add metadata value for presence of video channel in video blobs #42431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfalcao
approved these changes
Jun 9, 2021
|
Hey @lfalcao. Why are you approving PRs in this repository? |
|
@brenogazzola can you rebase this PR? |
Hi, I thought that reviewing merges would help both core members and contributors. If that's not being helpful I stop, no problem 🙇 |
|
Ah, sorry, that is fine, it is actually why I asked. It is helpful but I could not distinguish between a real user activity and a bot activity. |
brenogazzola
force-pushed
the
activestorage/videochannel
branch
from
436fc3f
to
b6e3220
Compare
|
@rafaelfranca Done |
zzak
approved these changes
Jun 10, 2021
brenogazzola
force-pushed
the
activestorage/videochannel
branch
from
b6e3220
to
3ad28fb
Compare
brenogazzola
force-pushed
the
activestorage/videochannel
branch
from
3ad28fb
to
48a7ec4
Compare
pixeltrix
approved these changes
Jun 20, 2021
|
@brenogazzola thanks 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Complement to #42392
Related to rails/marcel#57
While building video editing capabilities in our app, we've stumbled on a bit of an edge case. Android's voice recorder saves files as
m4abut encodes with 3GP (ftyp3gp4), which is a container for both audio and video. Marcel recognizes it as video, and this ends up breaking our pipeline, which is expecting to be able to use video filters on any video file.This PR adds
videoboolean entry to the video analyzer, to indicate whether the file has a video channel or not.Other Information
If you believe this PR makes sense, it might be better for me to close it and add the code to #42392. I've only separated it because I was not sure it would be approved.
While
audiofelt like a good key for presence/absence of audio channel, I'm not so sure about avideokey in a video file. Might be better them tovideo_channelandaudio_channelI think (or maybe_stream).