Fix disable_joins when join foreign key is not ID #42448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
changed the title
|
Thank you for this fix! 🎉 |
If you have a `has_one through` assocation where the `through` has a `belongs_to` the foreign key won't be `id` for the joins. This change ensures we use the correct foreign key when querying with disable joins turned off. Prior to this change the call to `project.lead_developer` would return `nil` if `disable_joins` was set. Project has one lead developer through firm. Project also belongs to firm. So when we call `project.lead_developer` it needs to find the lead developer through the firm. In these cases we don't want to read the owners id, we want to read the attribute that will give us the value of the first chain item's `join_foreign_key`.
eileencodes
force-pushed
the
fix-has_one-with-has_many-disable_joins
branch
from
bf9d4d6
to
566c403
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a
has_one throughassociation where thethroughhas abelongs_tothe foreign key won't beidfor the joins. This changeensures we use the correct foreign key when querying with disable joins
turned off. Prior to this change the call to
project.lead_developerwould return
nilifdisable_joinswas set.Project has one lead developer through firm. Project also belongs to
firm. So when we call
project.lead_developerit needs to find thelead developer through the firm. In these cases we don't want to read
the owners id, we want to read the attribute that will give us the
value of the first chain item's
join_foreign_key.