Get rid of cattr_accessor
in ActiveRecord::Base
#42451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #42442 for full context.
In short class variables are slow, particularly in classes with many ancestors, and
ActiveRecord::Base
has over 60 ancestors.Only a small handful of these really matter performance wise, however the idea is to migrate them all regardless for consistency and to ensure future contributors will follow the new pattern rather than add new
mattr/cattr
.This should be the last ones in
ActiveRecord::Base
. There are others in other Active Record classes, but since they don't have large ancestor chains, it doesn't matter much.I'll look at other classes with large ancestors chains instead (
ActionController::Base
?)