[ci skip] Fix inaccurate callback documentation #42461
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42457
Other Information
The callback de-deduplication logic currently happens at the time callbacks are set on a model. A fix that would implicitly solve a few issues around de-duping would be to apply the following for all callbacks accepting symbolized method names:
on_update
) and dynamically de-duplicate invocations of a specific method here. This would implicitly stop duplicate predicate methods from running in the cases of overlappingif
andunless
conditions while also allowing for distinctif
andunless
conditions to pass in the same symbolized method name for the same callback method.