Extract methods assert_queries and assert_no_queries

[ricardotk002]

Summary

Inspired by https://github.com/rails/rails/pull/40842/files#r650377037

Both methods are defined in multiple parts of the framework. It would
be useful to put them in a proper place, so that repetition is
avoided.

I chose the implementation from ActiveRecord because it's a bit more
complete with the SQLCounter class, and also because other parts
depend on it.

[pixeltrix]

Can we move this to ActiveRecord::Testing::QueryAssertions - we don't want to pollute the Active Support code with references to Active Record, thanks. Other than that looks good 👍🏻

[ricardotk002]

@pixeltrix Makes sense. I pushed new changes to address that.

[pixeltrix]

@ricardotk002 thanks for the quick turnaround on the changes 👍🏻

[rafaelfranca]

This is exposing those helpers to applications. We removed them years ago. Even though this is adding as private API, I think it would be better to not expose this on lib. Is that code duplication that bad?

[ricardotk002]

I agree that it probably shouldn't be exposed to the public. Still, I think there's a necessity for verifying the absence of N+1 queries in some parts of the framework (ActiveStorage, ActionText, etc); plus the implementation for assert_queries doesn't seem trivial, in most cases you'll find yourself copying/pasting it from somewhere else. I'm happy to follow another approach to keep it as a private API, if needed.

[rafaelfranca]

I think we should wait this duplication become a pain before trying to extract. I'm fine with copying parts of the implementation for all the places that need them. At this points this is already in all frameworks that need it already.

[pixeltrix]

I think we should wait this duplication become a pain before trying to extract. I'm fine with copying parts of the implementation for all the places that need them. At this points this is already in all frameworks that need it already.

The reason I suggested extracting it was that it was copied as part of #40842 so it seemed like a good point to do it with it being in three places but it's not a hill I'm going to die on if people feel strongly the other way 🙃