Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Active Storage & Action Text eager loading #42477

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Document Active Storage & Action Text eager loading #42477

merged 2 commits into from
Jun 14, 2021

Conversation

ghiculescu
Copy link
Member

@ghiculescu ghiculescu commented Jun 14, 2021 •
edited

@ghiculescu @p8
Update activestorage/app/models/active_storage/variant_with_record.rb
1c11237 
Co-authored-by: Petrik de Heus <petrik@deheus.net>
@pixeltrix pixeltrix merged commit b2d35c4 into rails:main Jun 14, 2021
@ghiculescu ghiculescu deleted the document-as-eager-loads branch June 14, 2021 18:56
@pixeltrix
Copy link
Contributor

@ghiculescu thanks! 👍🏻

@pixeltrix
Copy link
Contributor

pixeltrix commented Jun 15, 2021 •
edited

@ghiculescu just noticed this in the Action Text guide:
https://guides.rubyonrails.org/action_text_overview.html#avoid-n-1-queries

Perhaps a similar section in the Active Storage guide?

@ghiculescu ghiculescu mentioned this pull request Jun 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p8 p8 p8 left review comments

@pixeltrix pixeltrix pixeltrix approved these changes

Assignees
No one assigned
Labels
actiontext activestorage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ghiculescu @pixeltrix @p8