[ci skip] Improved Active Model Basics #42479
Conversation
guides/source/active_model_basics.md
Outdated
| @@ -185,7 +185,7 @@ irb> person.changes | |||
| => {"first_name"=>[nil, "First Name"]} | |||
| ``` | |||
|
|
|||
| #### Attribute based accessor methods | |||
| #### Attribute-based accessor methods | |||
There was a problem hiding this comment.
Could you create a separate PR just fixing all "x based" constructs where it should be "x-based.
For example, I think the following should probably be "string-based" instead.
guides/source/active_model_basics.md
Outdated
| @@ -65,7 +65,7 @@ irb> person.age_highest? | |||
| ### Callbacks | |||
|
|
|||
| `ActiveModel::Callbacks` gives Active Record style callbacks. This provides an | |||
| ability to define callbacks which run at appropriate times. | |||
| ability to define callbacks that run at appropriate times. | |||
There was a problem hiding this comment.
Although I prefer that here instead of which, which seems still allowed according to Merriam-Webster:
if your clause is bracketed by commas (“the article on grammar, which I started while eating lunch, seemed to never end”) it is likely a nonrestrictive clause, and you can give it a which. If it is not surrounded by commas, then it is most likely a restrictive clause, and you can choose to give it a that or a which. If anyone questions your decision, you can say that you are following the advice of the Fowlers, and are making a decision based on custom, euphony, and convenience.
https://www.merriam-webster.com/words-at-play/when-to-use-that-and-which
This change is arbitrary and someone else might just as well make the case to change it back to which.
guides/source/active_model_basics.md
Outdated
| @@ -323,7 +323,7 @@ objects. | |||
| ### Serialization | |||
|
|
|||
| `ActiveModel::Serialization` provides basic serialization for your object. | |||
| You need to declare an attributes Hash which contains the attributes you want to | |||
| You need to declare an attributes Hash that contains the attributes you want to | |||
guides/source/active_model_basics.md
Outdated
| @@ -500,7 +500,7 @@ a `password` accessor with certain validations on it by default. | |||
|
|
|||
| `ActiveModel::SecurePassword` depends on [`bcrypt`](https://github.com/codahale/bcrypt-ruby 'BCrypt'), | |||
| so include this gem in your `Gemfile` to use `ActiveModel::SecurePassword` correctly. | |||
| In order to make this work, the model must have an accessor named `XXX_digest`. | |||
| To make this work, the model must have an accessor named `XXX_digest`. | |||
guides/source/active_model_basics.md
Outdated
| @@ -485,8 +485,8 @@ Finished in 0.024899s, 240.9735 runs/s, 1204.8677 assertions/s. | |||
| 6 runs, 30 assertions, 0 failures, 0 errors, 0 skips | |||
| ``` | |||
|
|
|||
| An object is not required to implement all APIs in order to work with | |||
| Action Pack. This module only intends to provide guidance in case you want all | |||
| An object is not required to implement all APIs to work with | |||
|
@AdityaBhutani Could you please squash your commits? |
AdityaBhutani
force-pushed
the
fix-and-improve-guide-active-model-basics
branch
from
75d5cf4
to
2a3bf32
Compare
Summary
Improved Sentence by making it concise.
Fixed Grammatical Errors.