[ci skip] Fixing all <x> based occurances to <x>-based #42485
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
reviewed
Jun 15, 2021
| @@ -6433,7 +6433,7 @@ Tween.propHooks = { | |||
| }; | |||
|
|
|||
| // Support: IE9 | |||
| // Panic based approach to setting things on disconnected nodes | |||
| // Panic-based approach to setting things on disconnected nodes | |||
There was a problem hiding this comment.
This is third party code. No need to update it.
There was a problem hiding this comment.
Oh got It. Updated.
zzak
requested changes
Jun 16, 2021
guides/source/4_2_release_notes.md
Outdated
| @@ -819,7 +819,7 @@ Please refer to the [Changelog][active-support] for detailed changes. | |||
| `Numeric#from_now`. | |||
| ([Commit](https://github.com/rails/rails/commit/f1eddea1e3f6faf93581c43651348f48b2b7d8bb)) | |||
|
|
|||
| * Removed deprecated string based terminators for `ActiveSupport::Callbacks`. | |||
| * Removed deprecated string-based terminators for `ActiveSupport::Callbacks`. | |||
There was a problem hiding this comment.
We do not need to update these old release notes files.
AdityaBhutani
force-pushed
the
correct-all-x-based-occurances
branch
from
e8886a4
to
32af6ad
Compare
zzak
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed all based occurances to -based
as Suggested in 42479