Active Storage: docs on lazy vs immediate loading #42495
Conversation
|
@wbharding @RSO I used some of your examples from #40842 for this. Can you please have a look and see if they make sense? @pixeltrix FYI |
| @@ -687,6 +687,38 @@ previewable files. You can also call these methods directly. | |||
| [`representable?`]: https://api.rubyonrails.org/classes/ActiveStorage/Blob/Representable.html#method-i-representable-3F | |||
| [`representation`]: https://api.rubyonrails.org/classes/ActiveStorage/Blob/Representable.html#method-i-representation | |||
|
|
|||
| ### Lazy vs Immediate Loading | |||
There was a problem hiding this comment.
I think loading is a bit ambiguous here. Is it about lazily processing the images or about redirecting the back to the app first?
Maybe:
| ### Lazy vs Immediate Loading | |
| ### Lazy vs Immediate Processing |
There was a problem hiding this comment.
I think "lazy loading" is a much more commonly used term to describe the pattern. So I would rather stick with that, in case a user is confused by the terminology and googles it.
vs
There was a problem hiding this comment.
Ok, but in this case it's mostly about deferring the processing to another request right? At least the first time, when blobs haven't been processed...
|
|
||
| ```ruby | ||
| user.avatars.with_all_variant_records.each do |file| | ||
| image_tag file.representation(resize_to_limit: [100, 100]).processed.url |
There was a problem hiding this comment.
This will process all N files on the first access right?
There was a problem hiding this comment.
Should we maybe at a warning that it can make pages slow?
There was a problem hiding this comment.
I guess maybe this isn't direct enough...
I could do followup.
There was a problem hiding this comment.
This also bypasses HTTP caching, as it will create a new temporary url each time it's called.
So you need to either cache the url or users will download the file every time they access the page.
Co-authored-by: Petrik de Heus <petrik@deheus.net>
|
Late to the party, but looks good to me. A small nitpick would be that I don't think users will have many avatars typically, but that shouldn't be an issue in understanding what this is about. Side note: Is |
|
@RSO It's a wrapper so you don't have to think about if you need
|
|
@RSO maybe we should use |
Originally discovered by @RSO in #42495 (comment)
|
Fixed in 9c091b4 |
Follow up to #42477 (comment)