Set Active Record configurations on after_initialize #42499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
fix-activerecord-config-ordering
branch
from
36422f7
to
374b73c
Compare
| @@ -236,6 +228,18 @@ class Railtie < Rails::Railtie # :nodoc: | |||
| end | |||
| end | |||
|
|
|||
| initializer "active_record.set_config", after: :load_config_initializers do |app| | |||
There was a problem hiding this comment.
This also wrok for config/initializers but Railties will still not be able to set config. I think this should happen as late is possible, maybe in an after_initialize. That would avoid the need to use the after: option.
There was a problem hiding this comment.
Yeah, I tried that before and it wouldn't work, but it now does. Quite puzzling. Either way i think it's good to go now.
|
d7a857f caused a lot more failures and active record has a lot of deprecation warnings in the tests. Can we revert the changes to |
|
Done in 0305815 |
casperisfine
force-pushed
the
fix-activerecord-config-ordering
branch
2 times, most recently
from
bc017bb
to
8561bb7
Compare
casperisfine
changed the title
casperisfine
force-pushed
the
fix-activerecord-config-ordering
branch
2 times, most recently
from
b459889
to
d2351fe
Compare
Otherwise you can't change `config.active_record.*` from `config/initializers`. Until now it somewhat worked because the config would be assigned when `ActiveRecord::Base` would be first referenced. But it was quite brittle anyway.
casperisfine
force-pushed
the
fix-activerecord-config-ordering
branch
from
d2351fe
to
538998d
Compare
rafaelfranca
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise you can't change
config.active_record.*fromconfig/initializers.Until now it somewhat worked because the config would be assigned when
ActiveRecord::Basewould be first referenced. But it was quite brittle anyway.I might merge this one quickly once I get a green CI as to fix the
mainbranch. But I'd love to have second opinions on it.