Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ActiveStorage 'Linking to Files' section in guides [ci skip] #42500

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Improve ActiveStorage 'Linking to Files' section in guides [ci skip] #42500

merged 1 commit into from
Jun 16, 2021

Conversation

p8
Copy link
Member

@p8 p8 commented Jun 15, 2021

Summary

  • Improve the first paragraph, especially the first sentence, which
    described what to do, but not how to do it.
  • Add an example of what the URL's will look like, to make it clearer
    URLs link back to the application.
  • Link to the url_for and signed_id api docs.

@rails-bot rails-bot bot added the docs label Jun 15, 2021
ghiculescu
ghiculescu reviewed Jun 15, 2021
View reviewed changes
guides/source/active_storage_overview.md Outdated
```

WARNING: The links generated by ActiveStorage are hard to guess, but publicly
When the URL is accessed a redirect to the actual service endpoint is returned.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - I also tried to make this a bit clearer in #42495

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of activity in the ActiveStorage guides 😄

@p8
Improve ActiveStorage 'Linking to Files' section in guides [ci skip]
f838a6e 
* Improve the first paragraph, especially the first sentence, which
  described what to do, but not how to do it.
* Add an example of what the URL's will look like, to make it clearer
  URLs link back to the application.
* Link to the `url_for` and `signed_id` api docs.
@zzak zzak merged commit b430a94 into rails:main Jun 16, 2021
@p8 p8 deleted the guides/activestorage-improve-linking-section branch June 16, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghiculescu ghiculescu ghiculescu left review comments

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@p8 @ghiculescu @zzak